0.1.3 Orchestration: cron and airflow #50
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharchou
added
enhancement
mrutunjay-kinagi
requested changes
Oct 23, 2024
There was a problem hiding this comment.
This is a great start. I suggest you move this to a package eg: .../local_data_platform/cron/{your_python_script}
Let's say an end user wants to use any cron functionality then they would simply do
"""
from local_data_platform.cron import cron_flow
"""
There was a problem hiding this comment.
Looks good. Can we add logger module to add logs for eg. in exception part @brmhastra @mrutunjay-kinagi @tusharchou This way it will be easy to debug in case pipeline breaks.
above point is for all python scripts written till now and is not only subjected to this PR only.
we can add logger module in later stages as well.
tusharchou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defined cron functions